Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: CSS Nesting implementation #9549

Closed
wants to merge 78 commits into from
Closed

feat: CSS Nesting implementation #9549

wants to merge 78 commits into from

Commits on Nov 19, 2023

  1. Semi working

    @AlbertMarashi
    AlbertMarashi committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    4ded50f View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Working CSS nesting implementation

    @AlbertMarashi
    AlbertMarashi committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    a3d4eaf View commit details
    Browse the repository at this point in the history

  2. Merge branches 'main' and 'main' of https://github.com/sveltejs/svelte

    @AlbertMarashi
    AlbertMarashi committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    68713ee View commit details
    Browse the repository at this point in the history

  3. Add changeset

    @AlbertMarashi
    AlbertMarashi committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    8756de3 View commit details
    Browse the repository at this point in the history

  4. Remove some unused testing code

    @AlbertMarashi
    AlbertMarashi committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    2661f4e View commit details
    Browse the repository at this point in the history

  5. Remove unused testing code

    @AlbertMarashi
    AlbertMarashi committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    0e67006 View commit details
    Browse the repository at this point in the history

  6. Handle rule nesting, remove NestedSelector from SimpleSelector, impro… 

    …ve logic for encapsulation
    @AlbertMarashi
    AlbertMarashi committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    d9174c4 View commit details
    Browse the repository at this point in the history

  7. use for of

    @AlbertMarashi
    AlbertMarashi committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    b59387b View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Got CSS combinator prefixes working 

    Excluding CSS type element selectors

closes sveltejs#9320
closes sveltejs#8587
    @AlbertMarashi
    AlbertMarashi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    fcdc02e View commit details
    Browse the repository at this point in the history

  2. closes sveltejs#9320 

    closes sveltejs#8587
    @AlbertMarashi
    AlbertMarashi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    dab01b1 View commit details
    Browse the repository at this point in the history

  3. Implement full CSS nesting support 

    - parsing of at-rules
- parsing of element type selectors
    @AlbertMarashi
    AlbertMarashi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    05e959c View commit details
    Browse the repository at this point in the history

  4. Update changeset message

    @AlbertMarashi
    AlbertMarashi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    1ba667d View commit details
    Browse the repository at this point in the history

  5. Remove some unused code/comments

    @AlbertMarashi
    AlbertMarashi committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    b0397d1 View commit details
    Browse the repository at this point in the history

  6. Update .changeset/small-kids-switch.md 

    Co-authored-by: Ben McCann <[email protected]>
    @AlbertMarashi @benmccann
    AlbertMarashi and benmccann authored Nov 27, 2023
    Configuration menu
    Copy the full SHA
    a37b975 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Revert contributor change

    @AlbertMarashi
    AlbertMarashi committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    48c6cdf View commit details
    Browse the repository at this point in the history

  2. Merge branch 'css-nesting' of https://github.com/AlbertMarashi/svelte … 

    …into css-nesting
    @AlbertMarashi
    AlbertMarashi committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    2291dc3 View commit details
    Browse the repository at this point in the history

  3. Minor change 

    Not sure how to handle unused selectors & etc with CSS nestign
    @AlbertMarashi
    AlbertMarashi committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    2b4e730 View commit details
    Browse the repository at this point in the history

  4. Modify comment

    @AlbertMarashi
    AlbertMarashi committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    b6b872c View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Add additional test fixing bug with multiple nested layers

    @AlbertMarashi
    AlbertMarashi committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    a8fb36d View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Merge branch 'main' into css-nesting

    @AlbertMarashi
    AlbertMarashi authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    21d5daf View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. fix syntax error

    @Rich-Harris
    Rich-Harris committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    92f1e3a View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2024

  1. Handle CSS nesting by adding invisible selectors before nested rules

    @AlbertMarashi
    AlbertMarashi committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    6373f16 View commit details
    Browse the repository at this point in the history

  2. Correct comment

    @AlbertMarashi
    AlbertMarashi committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    b5444cf View commit details
    Browse the repository at this point in the history

  3. Added a failing test

    @AlbertMarashi
    AlbertMarashi committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    7e2875b View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Merge branch 'main' into pr/9549

    @Rich-Harris
    Rich-Harris committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    7ea05ce View commit details
    Browse the repository at this point in the history

  2. prettier

    @Rich-Harris
    Rich-Harris committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    61497b2 View commit details
    Browse the repository at this point in the history

  3. partial fix

    @Rich-Harris
    Rich-Harris committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    751c73c View commit details
    Browse the repository at this point in the history

  4. remove unused export keyword

    @Rich-Harris
    Rich-Harris committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    bdccdcb View commit details
    Browse the repository at this point in the history

  5. move type annotation

    @Rich-Harris
    Rich-Harris committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    633e05a View commit details
    Browse the repository at this point in the history

  6. use NestingSelector everywhere, include in SimpleSelector

    @Rich-Harris
    Rich-Harris committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    4d4d973 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Push some broken code, added block nested groupings

    @AlbertMarashi
    AlbertMarashi committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    b884dae View commit details
    Browse the repository at this point in the history

  2. Started working on encapsulation logic

    @AlbertMarashi
    AlbertMarashi committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    46efb43 View commit details
    Browse the repository at this point in the history

  3. Wohooo. Almost working

    @AlbertMarashi
    AlbertMarashi committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    0708f16 View commit details
    Browse the repository at this point in the history

  4. 2 failing tests

    @AlbertMarashi
    AlbertMarashi committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    eef0b3b View commit details
    Browse the repository at this point in the history

  5. Refactor a bunch of code

    @AlbertMarashi
    AlbertMarashi committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    8f347a9 View commit details
    Browse the repository at this point in the history

  6. Getting closer

    @AlbertMarashi
    AlbertMarashi committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    20629ca View commit details
    Browse the repository at this point in the history

  7. Even closer

    @AlbertMarashi
    AlbertMarashi committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    862be02 View commit details
    Browse the repository at this point in the history

  8. One test left!

    @AlbertMarashi
    AlbertMarashi committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    ef4b743 View commit details
    Browse the repository at this point in the history

  9. Comment out some console.logs

    @AlbertMarashi
    AlbertMarashi committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    1000cdf View commit details
    Browse the repository at this point in the history

  10. All tests passing & clean up a little bit of code

    @AlbertMarashi
    AlbertMarashi committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    89667b4 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Rever launch.json changes

    @AlbertMarashi
    AlbertMarashi committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    8c81aa7 View commit details
    Browse the repository at this point in the history

  2. Add more tests

    @AlbertMarashi
    AlbertMarashi committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    51016b5 View commit details
    Browse the repository at this point in the history

  3. Enhance logic and add some more tests

    @AlbertMarashi
    AlbertMarashi committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    c1dfaaf View commit details
    Browse the repository at this point in the history

  4. Clean some logic

    @AlbertMarashi
    AlbertMarashi committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    015e695 View commit details
    Browse the repository at this point in the history

  5. Update deprecated function

    @AlbertMarashi
    AlbertMarashi committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    bd37582 View commit details
    Browse the repository at this point in the history

  6. prettier

    @Rich-Harris
    Rich-Harris committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    4b4922e View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. merge main

    @Rich-Harris
    Rich-Harris committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    337b162 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. WIP Test

    @AlbertMarashi
    AlbertMarashi committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    055ec38 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'css-nesting' of https://github.com/AlbertMarashi/svelte … 

    …into css-nesting
    @AlbertMarashi
    AlbertMarashi committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    e075ad7 View commit details
    Browse the repository at this point in the history

  3. Add test expected result

    @AlbertMarashi
    AlbertMarashi committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    a421705 View commit details
    Browse the repository at this point in the history

  4. Pass all tests

    @AlbertMarashi
    AlbertMarashi committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    b9b4cab View commit details
    Browse the repository at this point in the history

  5. Pass test for invalid characters and simplify block item parse code

    @AlbertMarashi
    AlbertMarashi committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    f6a7796 View commit details
    Browse the repository at this point in the history

  6. Add multiple nesting selector support

    @AlbertMarashi
    AlbertMarashi committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    fb09917 View commit details
    Browse the repository at this point in the history

  7. Lol wot? Apparently I didn't need that logic

    @AlbertMarashi
    AlbertMarashi committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    9c5c05e View commit details
    Browse the repository at this point in the history

  8. Remove some unused logic

    @AlbertMarashi
    AlbertMarashi committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    26ba130 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. avoid try-catch

    @Rich-Harris
    Rich-Harris committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    2c3cdab View commit details
    Browse the repository at this point in the history

  2. prettier

    @Rich-Harris
    Rich-Harris committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    a528ee6 View commit details
    Browse the repository at this point in the history

  3. we really don't need all these tests, it's overkill. one will do. sti… 

    …ll some bugs
    @Rich-Harris
    Rich-Harris committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    bb8993b View commit details
    Browse the repository at this point in the history

  4. tweak

    @Rich-Harris
    Rich-Harris committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    32da098 View commit details
    Browse the repository at this point in the history

  5. unused import

    @Rich-Harris
    Rich-Harris committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    a46d9fd View commit details
    Browse the repository at this point in the history

  6. comment out rules with unused/empty children

    @Rich-Harris
    Rich-Harris committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    1543993 View commit details
    Browse the repository at this point in the history

  7. tweak

    @Rich-Harris
    Rich-Harris committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    4a7ac18 View commit details
    Browse the repository at this point in the history

  8. update test

    @Rich-Harris
    Rich-Harris committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    f03e316 View commit details
    Browse the repository at this point in the history

  9. generate wrappers during parse, allow rules to contain atrules

    @Rich-Harris
    Rich-Harris committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    a53fa5a View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. move grouping logic into Selector

    @Rich-Harris
    Rich-Harris committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    67bf628 View commit details
    Browse the repository at this point in the history

  2. shrink things down a touch

    @Rich-Harris
    Rich-Harris committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    3d0a885 View commit details
    Browse the repository at this point in the history

  3. simplify

    @Rich-Harris
    Rich-Harris committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    6e149f2 View commit details
    Browse the repository at this point in the history

  4. simplify

    @Rich-Harris
    Rich-Harris committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    353d697 View commit details
    Browse the repository at this point in the history

  5. actually we don't need that

    @Rich-Harris
    Rich-Harris committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    84b6f8b View commit details
    Browse the repository at this point in the history

  6. shrink explanation

    @Rich-Harris
    Rich-Harris committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    36123fc View commit details
    Browse the repository at this point in the history

  7. move

    @Rich-Harris
    Rich-Harris committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    ecff925 View commit details
    Browse the repository at this point in the history

  8. rename

    @Rich-Harris
    Rich-Harris committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    1f23ce5 View commit details
    Browse the repository at this point in the history

  9. rename

    @Rich-Harris
    Rich-Harris committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    ec49db4 View commit details
    Browse the repository at this point in the history

  10. That nested rule wasn't empty

    @AlbertMarashi
    AlbertMarashi committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    f6ba25c View commit details
    Browse the repository at this point in the history

  11. Merge branch 'css-nesting' of github.com:AlbertMarashi/svelte into pr… 

    …/9549
    @Rich-Harris
    Rich-Harris committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    0212055 View commit details
    Browse the repository at this point in the history

  12. revert

    @Rich-Harris
    Rich-Harris committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    4201cf7 View commit details
    Browse the repository at this point in the history

  13. merge main

    @Rich-Harris
    Rich-Harris committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    e3b84d5 View commit details
    Browse the repository at this point in the history

  14. merge main

    @Rich-Harris
    Rich-Harris committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    d470e13 View commit details
    Browse the repository at this point in the history