Skip to content

fix: backwards compatibility for types #8721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 18, 2023
Merged

fix: backwards compatibility for types #8721

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
64e7987
fix:backwards compatibility for types
gtm-nayan Jun 11, 2023
94522ee
update package json
gtm-nayan Jun 11, 2023
26c5568
what an idiot
gtm-nayan Jun 11, 2023
c3730b8
replace SvelteComponentDev
gtm-nayan Jun 11, 2023
d6b7b24
work already
gtm-nayan Jun 11, 2023
ba3140d
remove indirection
gtm-nayan Jun 12, 2023
e9d9dec
this maybe?
gtm-nayan Jun 12, 2023
b52339b
hardcode directories
gtm-nayan Jun 15, 2023
fbe3ba5
would this do anything?
gtm-nayan Jun 15, 2023
46c6c77
format
gtm-nayan Jun 15, 2023
d8a1bec
Revert "would this do anything?"
gtm-nayan Jun 15, 2023
a6c6fc5
Merge branch 'version-4' into types-backcompat
gtm-nayan Jun 15, 2023
e828216
no internal.d.ts
dummdidumm Jun 15, 2023
edc2ded
Merge branch 'version-4' into types-backcompat
dummdidumm Jun 16, 2023
734bdd7
fix file endings
dummdidumm Jun 16, 2023
0ad3db3
generate index signature manually
dummdidumm Jun 16, 2023
d067e2e
work around dts-buddy bug
dummdidumm Jun 17, 2023
d8570c2
simplify a bit
dummdidumm Jun 18, 2023
0195883
changeset
dummdidumm Jun 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/svelte/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,13 @@
"node": ">=16"
},
"types": "types/index.d.ts",
"typesVersions": {
"*": {
"*": [
"types/faux/*"
]
}
},
"scripts": {
"format": "prettier . --cache --plugin-search-dir=. --write",
"check": "prettier . --cache --plugin-search-dir=. --check",
Expand Down
17 changes: 17 additions & 0 deletions packages/svelte/scripts/generate-dts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,28 @@
import * as fs from 'fs';
import { createBundle } from 'dts-buddy';

fs.mkdirSync('types/faux', { recursive: true });
fs.readdirSync('src/runtime', { withFileTypes: true })
.filter((dirent) => dirent.isDirectory())
.forEach((dirent) =>
Copy link
Member

@dummdidumm dummdidumm Jun 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this include internal? Should be filtered out probably

fs.writeFileSync(`types/faux/${dirent.name}.d.ts`, `import '../index.d.ts';`)
);

fs.writeFileSync('types/faux/index.d.ts', `import '../index.d.ts';`);
fs.writeFileSync('types/faux/compiler.d.ts', `import '../index.d.ts';`);

// TODO: some way to mark these as deprecated
fs.mkdirSync('types/faux/types/compiler', { recursive: true });
fs.writeFileSync('types/faux/types/compiler/preprocess.d.ts', `import '../index.d.ts';`);
fs.writeFileSync('types/faux/types/compiler/interfaces.d.ts', `import '../index.d.ts';`);

await createBundle({
output: 'types/index.d.ts',
modules: {
svelte: 'src/runtime/public.d.ts',
'svelte/compiler': 'src/compiler/public.d.ts',
'svelte/types/compiler/preprocess': 'src/compiler/preprocess/public.d.ts',
'svelte/types/compiler/interfaces': 'src/compiler/interfaces.d.ts',
Copy link
Member

@Rich-Harris Rich-Harris Jun 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What uses this?

Copy link
Contributor Author

@gtm-nayan gtm-nayan Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vite plugin svelte and at least one other thing on the CI list

Copy link
Member

@Rich-Harris Rich-Harris Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should update them to use svelte/compiler as soon as v4 is out, so that these entry points can be dropped in v5

'svelte/action': 'src/runtime/action/public.d.ts',
'svelte/animate': 'src/runtime/animate/public.d.ts',
'svelte/easing': 'src/runtime/easing/index.js',
Expand Down
2 changes: 1 addition & 1 deletion packages/svelte/src/runtime/ambient.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
declare module '*.svelte' {
export { SvelteComponentDev as default } from 'svelte/internal';
export { SvelteComponent as default } from 'svelte';
}
1 change: 1 addition & 0 deletions packages/svelte/src/runtime/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

"baseUrl": ".",
"paths": {
"svelte": ["."],
"svelte/*": ["*"]
},
"allowJs": true,
Expand Down