-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix]destroy empty component #7492
[fix]destroy empty component #7492
Conversation
e392792
to
35da0f5
Compare
… inconsistent with production mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add test?
OK. I will add test later. |
@baseballyama Already pushed. Have a look at it. 🤝 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the comments many times but I think we need to update the test!
😁 Indeed no bother at all, as concise code and better solution is what we both pursue. Thanks for your effort on careful reviewing. Already pushed. Have a look. |
@baseballyama Is this PR ready to merge? |
Yeah, it looks good to me but we need a review by at least one maintainer. |
Hi, @tanhauhau, could you please have a look at this PR ? I've noticed that you have committed " add typescript def for transitions (#5625)" to this file |
Hi, @dummdidumm , could you please have a look at this PR? It's a little bugfix and has been opened for 2 months. |
destroy empty component and fix fragment property value consistency as discussed in #7488
Before submitting the PR, please make sure you do the following
[feat]
,[fix]
,[chore]
, or[docs]
.Tests
npm test
and lint the project withnpm run lint