Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitions are not triggered for the else of an each-else block #4987

Closed

Conversation

khang8591
Copy link
Contributor

Issue #4970

Added #4970 (comment) fix

@pushkine

My first PR, please let me know if i need to add anything else.

Thanks!

@Conduitry
Copy link
Member

Thanks for the PR! This looks good so far, but I think we also need to handle the {:else} transitioning out when elements are added to the {#each} again.

@khang8591
Copy link
Contributor Author

I was able to figure out how to add an outtro, but in the original issue #4970, the animation for the outtro, the list items get added above the 'No Item' div, wasn't sure how to get it to do that, wondering if anyone can point me in the right direction?

Current behavior with this PR is the item list gets added back below the 'No item' div.

Thanks.

@Conduitry
Copy link
Member

This has been absorbed into #5179, which I just merged, and also gave you co-author credit while doing so. Thank you!

@Conduitry Conduitry closed this Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants