Fix check for uninitialized condition
in compound if block with static condition, needs_update and outros
#4841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4840
With a static if condition and both
needs_update
and outro support enabled on the if block, the check forcondition
(usually rendered asshow_if
in the generated code) is checked against -1 to see if the static function should be run, but the variable starts out uninitialized and so it doesn't get checked. This PR changes it to check for${condition} == null
instead, the same check used elsewhere in the file.Here's an annotated example from the original REPL:
Before submitting the PR, please make sure you do the following
npm run lint
!)Tests
npm test
oryarn test
)