Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest not using the word "outroing" #4434

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

jesseskinner
Copy link
Contributor

I've rewritten a sentence to avoid using the word "outroing". I came here thinking it was a typo of "outgoing", but discovered it is a term used internally with Svelte. I think the term is confusing and does not help people to learn Svelte.

Thanks!

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test)

I've rewritten a sentence to avoid using the word "outroing". I came here thinking it was a typo of "outgoing", but discovered it is a term used internally with Svelte. I think the term is confusing and does not help people to learn Svelte.

Thanks!
@Conduitry
Copy link
Member

I think this makes sense, thanks. There have been at least two other PRs before you that tried to change 'outroing' to 'outgoing', so this is probably confusing!

@Conduitry Conduitry merged commit c992f7a into sveltejs:master Feb 20, 2020
@jesseskinner jesseskinner deleted the patch-1 branch February 20, 2020 14:06
@jesseskinner jesseskinner removed the request for review from Rich-Harris February 20, 2020 14:14
sthagen added a commit to sthagen/sveltejs-svelte that referenced this pull request Feb 21, 2020
docs: reword to avoid "outroing" (sveltejs#4434)
jesseskinner added a commit to jesseskinner/svelte that referenced this pull request Feb 27, 2020
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants