Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix allow let scoped to root element #4266

Conversation

tanhauhau
Copy link
Member

Fixes #4173

@Conduitry
Copy link
Member

@tanhauhau Did you uncheck 'allow maintainers to push to this branch'? I'd like to push up some changes before merging this.

@tanhauhau
Copy link
Member Author

oops. i don't remember unchecking it.. 🙈

@Conduitry Conduitry merged commit 8b9b2c2 into sveltejs:master Jan 16, 2020
@tanhauhau tanhauhau deleted the tanhauhau/let-binding-on-scoped-to-root-element branch January 16, 2020 14:27
sthagen added a commit to sthagen/sveltejs-svelte that referenced this pull request Jan 16, 2020
fix allow let scoped to root element (sveltejs#4266)
jesseskinner pushed a commit to jesseskinner/svelte that referenced this pull request Feb 27, 2020
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slot let variables not accessible on slotted element root
2 participants