Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix $$invalidate getting confused by an undefined third argument (#4170) #4217

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

Conduitry
Copy link
Member

Fixes #4170. I investigated swapping the second and third arguments to $$invalidate but that ran into complications because the ret argument actually contains the assignment, and needs to be evaluated before the value argument. So, ultimately, I just used a ...rest argument, and value is getting manually set to rest.length ? rest[0] : ret.

@Conduitry Conduitry merged commit 3b0c6a1 into sveltejs:master Jan 6, 2020
@Conduitry Conduitry deleted the gh-4170 branch January 7, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Destructuring a store object retuns the whole store if the property does not exist
1 participant