Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include css in compiler output #417

Merged
merged 2 commits into from
Mar 28, 2017
Merged

include css in compiler output #417

merged 2 commits into from
Mar 28, 2017

Conversation

Rich-Harris
Copy link
Member

Nice simple solution to #409. Eventually we'll need to get CSS sourcemaps working as well, but this is a good first step which should hopefully enable tooling like rollup-plugin-svelte to make server-rendering CSS a bit easier.

@codecov-io
Copy link

codecov-io commented Mar 28, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@b9d3c23). Click here to learn what that means.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #417   +/-   ##
=========================================
  Coverage          ?   29.18%           
=========================================
  Files             ?       80           
  Lines             ?     2292           
  Branches          ?        0           
=========================================
  Hits              ?      669           
  Misses            ?     1623           
  Partials          ?        0
Impacted Files Coverage Δ
src/generators/server-side-rendering/index.js 11.62% <0%> (ø)
src/generators/dom/index.js 57.14% <100%> (ø)
src/generators/Generator.js 40.75% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9d3c23...b5d4b78. Read the comment docs.

@Rich-Harris Rich-Harris merged commit ec5995b into master Mar 28, 2017
@Rich-Harris Rich-Harris deleted the gh-409 branch March 28, 2017 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants