Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node 4 compatibility #353

Merged
merged 8 commits into from
Mar 7, 2017
Merged

Node 4 compatibility #353

merged 8 commits into from
Mar 7, 2017

Conversation

Rich-Harris
Copy link
Member

Ref #109. The compiler now works in Node 4, but the tests won't run due (I think) to a bad interaction between reify and buble/register. Tried babel-register with babel-preset-env as an alternative, but it failed for whatever reason, so this is still a WIP.

@Rich-Harris
Copy link
Member Author

Ok, have moved some tests files around so that we can use babel-register in old Node (so that we don't need to rewrite all the tests), and reify with new Node (because it's much faster than transpiling import/export with Babel)

@Rich-Harris Rich-Harris merged commit 67e39ad into master Mar 7, 2017
@Rich-Harris Rich-Harris changed the title [WIP] Node 4 compatibility Node 4 compatibility Mar 7, 2017
@Conduitry Conduitry deleted the gh-109 branch April 20, 2017 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Rich-Harris