only invalidate referenced values #2865
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR means that changes to local state only trigger an invalidation if the state is referenced in the markup, or in a reactive declaration, meaning less work and less code:
A more practical example:
There is a small change to observable behaviour (other than avoiding unnecessary work) —
beforeUpdate
andafterUpdate
will no longer fire when unreferenced local state changes. I think that's probably the correct behaviour anyway, since no 'update' is happening, and it's useful to be able to 'clear' those kinds of values inafterUpdate
without triggering another update (which necessitates the infinite loop guard).Thoughts?