Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for object-rest in each destructuring #2664

Merged
merged 1 commit into from
May 4, 2019
Merged

Add support for object-rest in each destructuring #2664

merged 1 commit into from
May 4, 2019

Conversation

EmilTholin
Copy link
Member

@EmilTholin EmilTholin commented May 3, 2019

This PR adds support for the object-rest syntax in the destructuring part of {#each} blocks.

Closes #2647

@akaufmann
Copy link

Hi @EmilTholin, there's someone who was faster than you => #2658.

@EmilTholin
Copy link
Member Author

Hi @akaufmann! I admittedly didn't see that PR, but that PR is for array rest, not object rest.

@akaufmann
Copy link

D'oh 😅 I missed that (had only in mind each and destructuring).

@Rich-Harris Rich-Harris merged commit 78332cf into sveltejs:master May 4, 2019
@Rich-Harris
Copy link
Member

this is mad and brilliant. I don't know of any existing utilities that could do the work of attach_head but I reckon this is good for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for object-rest in each destructuring
3 participants