Skip to content

fix: correctly differentiate static fields before emitting duplicate_class_field #16526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2025
Merged

fix: correctly differentiate static fields before emitting duplicate_class_field #16526

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3fdd3d
fix: correctly differentiate static fields before emitting `duplicate…
Ocean-OS Jul 30, 2025
f56a3ec
remove unnecessary `#` concatenation
Ocean-OS Jul 31, 2025
536ba7f
add test
Ocean-OS Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nine-cups-film.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: correctly differentiate static fields before emitting `duplicate_class_field`
10 changes: 8 additions & 2 deletions packages/svelte/src/compiler/phases/2-analyze/visitors/ClassBody.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,10 @@ export function ClassBody(node, context) {
e.state_field_duplicate(node, name);
}

const _key = (key.type === 'PrivateIdentifier' ? '#' : '') + name;
const _key =
(node.type === 'AssignmentExpression' || !node.static ? '' : '@') +
(key.type === 'PrivateIdentifier' ? '#' : '') +
name;
const field = fields.get(_key);

// if there's already a method or assigned field, error
Expand Down Expand Up @@ -91,7 +94,10 @@ export function ClassBody(node, context) {
if (child.kind === 'constructor') {
constructor = child;
} else if (!child.computed) {
const key = (child.key.type === 'PrivateIdentifier' ? '#' : '') + get_name(child.key);
const key =
(child.static ? '@' : '') +
(child.key.type === 'PrivateIdentifier' ? '#' : '') +
get_name(child.key);
const field = fields.get(key);
if (!field) {
fields.set(key, [child.kind]);
Expand Down
Loading