use props when passing data to custom elements (#875) #1636
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behaviour of attributes on custom elements — previously, data would always be passed to custom elements using
setAttribute
, which only works for strings.Now, it uses a simple heuristic: if the prop exists on the custom element, it is set as a prop, otherwise it's an attribute. (This is similar to what Preact does.)
So in this case...
...as long as
items
is the name of a property on aFancyList
instance (whether or not it had previously been set), the value ofitems
inside the component will be an array rather than the dreaded"[object Object]"
.Typically, custom elements use accessors for properties that their consumers should be able to read and write...
...and that's similar to the code Svelte generates for custom elements, so this ought to be a reliable heuristic. Meanwhile, unexpected props still become attributes, allowing this sort of thing:
With this PR, we pass all the tests on https://custom-elements-everywhere.com —
— which is better than React, Preact, and, err... Polymer, the custom element framework 😳