Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #1600 #1610

Merged
merged 1 commit into from
Jul 24, 2018
Merged

closes #1600 #1610

merged 1 commit into from
Jul 24, 2018

Conversation

ekhaled
Copy link
Contributor

@ekhaled ekhaled commented Jul 23, 2018

This happens because cancel is called before the onload event is fired on line 208.

This PR just checks for the existence of win before trying to remove the listener

@Rich-Harris Rich-Harris merged commit 264d65d into sveltejs:master Jul 24, 2018
@Rich-Harris
Copy link
Member

thank you 👍

@ekhaled ekhaled deleted the gh-1600 branch July 24, 2018 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants