Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure correct order of DOM insertions with neighbouring keyed each blocks #1309

Merged
merged 1 commit into from
Apr 4, 2018

Conversation

Rich-Harris
Copy link
Member

fixes #1306

@codecov-io
Copy link

codecov-io commented Apr 4, 2018

Codecov Report

Merging #1309 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1309   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files         124      124           
  Lines        4417     4417           
  Branches     1390     1390           
=======================================
  Hits         4042     4042           
  Misses        154      154           
  Partials      221      221
Impacted Files Coverage Δ
src/generators/nodes/EachBlock.ts 97.63% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4661fbb...dd24744. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 58dba84 into master Apr 4, 2018
@Rich-Harris Rich-Harris deleted the gh-1306 branch April 4, 2018 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOM order is not guaranteed when using keys
2 participants