Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CompileError constructor #1296

Merged
merged 1 commit into from
Apr 1, 2018
Merged

fix CompileError constructor #1296

merged 1 commit into from
Apr 1, 2018

Conversation

Rich-Harris
Copy link
Member

The belt to these braces — fixes an annoying bug that causes errors to get swallowed in favour of mysterious 'Cannot read property 'split' of undefined' messages

@codecov-io
Copy link

codecov-io commented Mar 30, 2018

Codecov Report

Merging #1296 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1296      +/-   ##
==========================================
- Coverage   91.66%   91.65%   -0.01%     
==========================================
  Files         122      122              
  Lines        4332     4328       -4     
  Branches     1367     1367              
==========================================
- Hits         3971     3967       -4     
  Misses        148      148              
  Partials      213      213
Impacted Files Coverage Δ
src/parse/index.ts 86.84% <100%> (-0.34%) ⬇️
src/validate/index.ts 89.79% <100%> (-0.41%) ⬇️
src/utils/error.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae25641...f6dd6ed. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 5d02b9e into master Apr 1, 2018
@Rich-Harris Rich-Harris deleted the fix-errors branch April 1, 2018 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants