Skip to content

fix: use snippet as parent element of snippets childrens in validator #11463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 8, 2024
Merged

fix: use snippet as parent element of snippets childrens in validator #11463

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0fdfcb4
fix: use snippet as parent element of snippets childrens in validator
paoloricciuti May 4, 2024
53569be
Update packages/svelte/src/compiler/phases/2-analyze/validation.js
Rich-Harris May 6, 2024
1aabba7
Update .changeset/wet-pears-remain.md
Rich-Harris May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wet-pears-remain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"svelte": patch
---

fix: use snippet as parent element of snippets childrens in validator
5 changes: 5 additions & 0 deletions packages/svelte/src/compiler/phases/2-analyze/validation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,6 +622,11 @@ const validation = {
SnippetBlock(node, context) {
validate_block_not_empty(node.body, context);

const old_parent = context.state.parent_element;
context.state.parent_element = 'snippet';
context.next(context.state);
context.state.parent_element = old_parent;

if (node.expression.name !== 'children') return;

const { path } = context;
Expand Down
1 change: 1 addition & 0 deletions packages/svelte/tests/validator/samples/non-invalid-node-placement-if-snippet/errors.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[]
10 changes: 10 additions & 0 deletions packages/svelte/tests/validator/samples/non-invalid-node-placement-if-snippet/input.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<table>
<tbody>
<tr>
{#snippet cell(v)}Value: {v}{/snippet}
{#each [1, 2, 3] as v}
<td>{@render cell(v)}</td>
{/each}
</tr>
</tbody>
</table>