fix handling of boolean attributes in SSR (#1109) #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ... have no idea what that build failure is about. It doesn't look like it's necessarily just Travis having a glitch. |
Codecov Report
@@ Coverage Diff @@
## master #1123 +/- ##
==========================================
+ Coverage 91.47% 91.48% +<.01%
==========================================
Files 125 125
Lines 4518 4522 +4
Branches 1457 1459 +2
==========================================
+ Hits 4133 4137 +4
Misses 163 163
Partials 222 222
Continue to review full report at Codecov.
|
|
Well it looks like the rebuild worked 🤷♂️ |
|
lol computers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an extra layer to this that I wasn't thinking of because I somehow forgot that we need to output code that outputs HTML, not just directly output HTML 😅
What I settled on was: If this is a known boolean attribute, and its value is exactly one non-Text chunk, then emit code that displays or doesn't display the bare attribute name as appropriate. Other situations are handled as before.