Skip to content

fix: try-catch deep read #10270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2024
Merged

fix: try-catch deep read #10270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
793b19a
fix: try-catch deep read
dummdidumm Jan 23, 2024
5d7ff44
changeset
dummdidumm Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/rich-waves-mix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"svelte": patch
---

fix: try-catch deep read during `$inspect`
12 changes: 10 additions & 2 deletions packages/svelte/src/internal/client/runtime.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1966,7 +1966,11 @@ function deep_read(value, visited = new Set()) {
if (typeof value === 'object' && value !== null && !visited.has(value)) {
visited.add(value);
for (let key in value) {
deep_read(value[key], visited);
try {
deep_read(value[key], visited);
} catch (e) {
// continue
}
}
const proto = Object.getPrototypeOf(value);
if (
Expand All @@ -1980,7 +1984,11 @@ function deep_read(value, visited = new Set()) {
for (let key in descriptors) {
const get = descriptors[key].get;
if (get) {
get.call(value);
try {
get.call(value);
} catch (e) {
// continue
}
}
}
}
Expand Down