Skip to content

fix main #10237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2024
Merged

fix main #10237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
031af31
fix main
trueadm Jan 19, 2024
e3d352a
fix main
trueadm Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/svelte/tests/compiler-errors/samples/unmatched-closing-tag-autoclose/_config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export default test({
error: {
code: 'invalid-closing-tag-after-autoclose',
message:
'</p> attempted to close element that was already automatically closed by <pre> (cannot nest <pre> inside <p>',
'</p> attempted to close element that was already automatically closed by <pre> (cannot nest <pre> inside <p>)',
position: [24, 24]
}
});
11 changes: 0 additions & 11 deletions packages/svelte/tests/store/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,6 @@ describe('derived', () => {
it('maps a single store', () => {
const a = writable(1);

// @ts-expect-error TODO feels like inference should work here
const b = derived(a, (n) => n * 2);

const values: number[] = [];
Expand All @@ -251,7 +250,6 @@ describe('derived', () => {
const a = writable(2);
const b = writable(3);

// @ts-expect-error TODO feels like inference should work here
const c = derived([a, b], ([a, b]) => a * b);

const values: number[] = [];
Expand Down Expand Up @@ -343,10 +341,8 @@ describe('derived', () => {
it('prevents glitches', () => {
const lastname = writable('Jekyll');

// @ts-expect-error TODO feels like inference should work here
const firstname = derived(lastname, (n) => (n === 'Jekyll' ? 'Henry' : 'Edward'));

// @ts-expect-error TODO feels like inference should work here
const fullname = derived([firstname, lastname], (names) => names.join(' '));

const values: string[] = [];
Expand All @@ -367,17 +363,14 @@ describe('derived', () => {

const values: string[] = [];

// @ts-expect-error TODO feels like inference should work here
const a = derived(count, ($count) => {
return 'a' + $count;
});

// @ts-expect-error TODO feels like inference should work here
const b = derived(count, ($count) => {
return 'b' + $count;
});

// @ts-expect-error TODO feels like inference should work here
const combined = derived([a, b], ([a, b]) => {
return a + b;
});
Expand All @@ -399,12 +392,10 @@ describe('derived', () => {

const values: string[] = [];

// @ts-expect-error TODO feels like inference should work here
const a = derived(root, ($root) => {
return 'a' + $root.a;
});

// @ts-expect-error TODO feels like inference should work here
const b = derived([a, root], ([$a, $root]) => {
return 'b' + $root.b + $a;
});
Expand All @@ -426,7 +417,6 @@ describe('derived', () => {

const number = writable(1);

// @ts-expect-error TODO feels like inference should work here
const numbers = derived(number, ($number) => {
arr[0] = $number;
return arr;
Expand Down Expand Up @@ -507,7 +497,6 @@ describe('derived', () => {
const a = writable('one');
const b = writable(1);

// @ts-expect-error TODO feels like inference should work here
const c = derived([a, b], ([a, b]) => `${a} ${b}`);

assert.deepEqual(get(c), 'one 1');
Expand Down