Skip to content

fix: only throw bind error when not passing a value #10090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 12, 2024
Merged

fix: only throw bind error when not passing a value #10090

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fa810e6
fix: only throw bind error when not passing a value
dummdidumm Jan 5, 2024
d3bf9f7
tweak error
dummdidumm Jan 9, 2024
a335053
Merge branch 'main' into prop-bind-error
dummdidumm Jan 9, 2024
beced2d
fix
dummdidumm Jan 9, 2024
e0066e0
Merge branch 'main' into prop-bind-error
dummdidumm Feb 12, 2024
7e9c974
tweak message
dummdidumm Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/big-geese-act.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: only throw bind error when not passing a value
13 changes: 6 additions & 7 deletions packages/svelte/src/internal/client/runtime.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1458,16 +1458,15 @@ export function is_store(val) {
export function prop(props, key, flags, initial) {
var immutable = (flags & PROPS_IS_IMMUTABLE) !== 0;
var runes = (flags & PROPS_IS_RUNES) !== 0;

var setter = get_descriptor(props, key)?.set;
if (DEV && setter && runes && initial !== undefined) {
// TODO consolidate all these random runtime errors
throw new Error('Cannot use fallback values with bind:');
}

var prop_value = /** @type {V} */ (props[key]);
var setter = get_descriptor(props, key)?.set;

if (prop_value === undefined && initial !== undefined) {
if (DEV && setter && runes) {
// TODO consolidate all these random runtime errors
throw new Error('Cannot use fallback values with bind:');
}

// @ts-expect-error would need a cumbersome method overload to type this
if ((flags & PROPS_IS_LAZY_INITIAL) !== 0) initial = initial();

Expand Down