Skip to content

rel attribute validation does not account for dynamic value #7994

@dominikg

Description

@dominikg

Describe the bug

Here

const rel_values = rel ? rel.get_static_value().split(' ') : [];

get_static_value() can return null and then null.split() happens.

Reproduction

https://svelte.dev/repl/b19472184dc6417fbcdc2077fc0593ee?version=3.52.0

Logs

8:57:24 PM [vite] Internal server error: Cannot read properties of null (reading 'split')
  Plugin: vite-plugin-svelte
  File: <snip>
      at Element.validate_special_cases (file:///home/dominikg/develop/sveltejs/svelte/compiler.mjs:20588:53)
      at Element.validate (file:///home/dominikg/develop/sveltejs/svelte/compiler.mjs:20350:9)
      at new Element (file:///home/dominikg/develop/sveltejs/svelte/compiler.mjs:20332:8)

System Info

System:
    OS: Linux 5.19 Manjaro Linux
    CPU: (16) x64 AMD Ryzen 9 5900HX with Radeon Graphics
    Memory: 47.34 GB / 62.21 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 18.11.0 - ~/.local/share/pnpm/node
    Yarn: 1.22.19 - ~/.local/share/pnpm/yarn
    npm: 8.19.2 - ~/.local/share/pnpm/npm
  Browsers:
    Chromium: 107.0.5304.87
    Firefox: 106.0.2
  npmPackages:
    rollup: ^1.27.14 => 1.27.14

Severity

blocking an upgrade

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions