Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deconflict names in SSR components #655

Closed
Rich-Harris opened this issue Jun 20, 2017 · 0 comments · Fixed by #674
Closed

Deconflict names in SSR components #655

Rich-Harris opened this issue Jun 20, 2017 · 0 comments · Fixed by #674
Labels
bug

Comments

@Rich-Harris
Copy link
Member

If you import a component with a name that conflicts with the component you're generating, you generate invalid JavaScript. This means that for example this file has to be called guidePage.html instead of just guide.html (reflecting its /guide URL), because it imports Guide. Ugh.
Rich-Harris added a commit that referenced this issue Jun 25, 2017
@Rich-Harris
deconflict name with imports (#655)
7ad4bef
@Rich-Harris Rich-Harris mentioned this issue Jun 25, 2017
Merged
Rich-Harris added a commit that referenced this issue Jun 25, 2017
@Rich-Harris
Merge pull request #674 from sveltejs/gh-655
b1d1cea 
deconflict name with imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deconflict name with imports sveltejs/svelte
1 participant
@Rich-Harris