Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Any set({}) during transition back transition element to previous state. #1575

Closed
stalkerg opened this issue Jul 3, 2018 · 1 comment · Fixed by #1585
Closed

Any set({}) during transition back transition element to previous state. #1575

stalkerg opened this issue Jul 3, 2018 · 1 comment · Fixed by #1585
Labels
bug

Comments

@stalkerg
Copy link
Contributor

stalkerg commented Jul 3, 2018 •
edited
Loading

It's happening because we not check current transition state and run groupOutros() again with set remaining to 0.
Looks like a classic race condition.
REPL:
https://svelte.technology/repl?version=2.9.1&gist=9436b31a1bdc913ec008e96a18eb19f0

it's working fine for 2.8.1 because we create a new object instead of change parameters in the existing object.
Problem in this commit: 7678b36
@stalkerg
Copy link
Contributor Author

stalkerg commented Jul 6, 2018 •
edited
Loading

This is one of a possible way to solve this problem:
stalkerg@7cab338

@stalkerg stalkerg mentioned this issue Jul 9, 2018
Merged
Rich-Harris added a commit that referenced this issue Jul 15, 2018
@Rich-Harris
alternative fix for #1575 - return to 2.8 behaviour
e17f3fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Fix outro race condition stalkerg/svelte
2 participants
@stalkerg @Conduitry