Merge pull request #2804 from kaisermann/fix/dataset-without-value

fix: 🐛 data attributes without value outputting as "true"
sveltejs · May 21, 2019 · 931c080 · 931c080
2 parents 394a166 + 335f77c
commit 931c080
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/src/compile/render-dom/wrappers/Element/Attribute.ts b/src/compile/render-dom/wrappers/Element/Attribute.ts
@@ -187,7 +187,7 @@ export default class AttributeWrapper {
 					: property_name
 						? `${element.var}.${property_name} = ${value};`
 						: is_dataset
-							? `${element.var}.dataset.${camel_case_name} = ${value};`
+							? `${element.var}.dataset.${camel_case_name} = ${value === true ? '""' : value};`
 							: `${method}(${element.var}, "${name}", ${value === true ? '""' : value});`
 			);
 

diff --git a/test/runtime/samples/attribute-dataset-without-value/_config.js b/test/runtime/samples/attribute-dataset-without-value/_config.js
@@ -0,0 +1,3 @@
+export default {
+	html: '<div data-potato=""></div>',
+};
diff --git a/test/runtime/samples/attribute-dataset-without-value/main.svelte b/test/runtime/samples/attribute-dataset-without-value/main.svelte
@@ -0,0 +1 @@
+<div data-potato></div>