Merge pull request #793 from sveltejs/gh-791

error if component has transition
sveltejs · Aug 29, 2017 · 502f6b6 · 502f6b6
2 parents 56677a2 + cb92f30
commit 502f6b6
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 0 deletions.
diff --git a/src/validate/html/validateElement.ts b/src/validate/html/validateElement.ts
@@ -116,6 +116,10 @@ export default function validateElement(validator: Validator, node: Node, refs:
 		} else if (attribute.type === 'EventHandler') {
 			validateEventHandler(validator, attribute, refCallees);
 		} else if (attribute.type === 'Transition') {
+			if (isComponent) {
+				validator.error(`Transitions can only be applied to DOM elements, not components`, attribute.start);
+			}
+
 			const bidi = attribute.intro && attribute.outro;
 
 			if (hasTransition) {

diff --git a/test/validator/samples/transition-on-component/errors.json b/test/validator/samples/transition-on-component/errors.json
@@ -0,0 +1,8 @@
+[{
+	"message": "Transitions can only be applied to DOM elements, not components",
+	"loc": {
+		"line": 1,
+		"column": 8
+	},
+	"pos": 8
+}]
diff --git a/test/validator/samples/transition-on-component/input.html b/test/validator/samples/transition-on-component/input.html
@@ -0,0 +1,15 @@
+<Widget in:foo/>
+
+<script>
+	import Widget from './Widget.html';
+
+	export default {
+		components: {
+			Widget
+		},
+
+		transitions: {
+			foo() {}
+		}
+	};
+</script>