Skip to content

Invalidate height map when items are deleted #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gliu20 wants to merge 2 commits into from
Closed

Invalidate height map when items are deleted #44

gliu20 wants to merge 2 commits into from

Conversation

@gliu20
Copy link

@gliu20 gliu20 commented Apr 30, 2020 •
edited
Loading

This does two things:

The issue occurs when filtering items with Svelte 3.21.0 VirtualList

cht8687
cht8687 reviewed Aug 4, 2020
View reviewed changes
VirtualList.svelte Outdated
start = 0
end = 0
return;
top = 0
Copy link

@cht8687 cht8687 Aug 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 40 to 42 is unreachable.

@gitbreaker222 gitbreaker222 mentioned this pull request Jan 23, 2021
Open
@gliu20 gliu20 closed this by deleting the head repository Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cht8687 cht8687 cht8687 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Get index of the item Viewport goes empty if scrolled down and items array changes.

2 participants

@gliu20 @cht8687