Refactor code, drop more legacy stuff#158
Conversation
non25
changed the title
benmccann
left a comment
benmccann
left a comment
There was a problem hiding this comment.
this PR looks like a good idea to me
This comment has been minimized.
This comment has been minimized.
|
This PR's a bit difficult to review since #159 was integrated. I just merged that one so if you rebase against |
Remove remainings of ExtractTextPlugin Move `css: false` to compilerOptions Remove externalDependencies, there's no such option anymore
I've got two conflicts rebasing! OMG! |
README.md
Outdated
| }, | ||
| extensions: ['.mjs', '.js', '.svelte'], | ||
| mainFields: ['svelte', 'browser', 'module', 'main'] | ||
| ... |
There was a problem hiding this comment.
I think this was easier to paste into your webpack config when indented since it'd be indented there. I'd probably revert the indentation changes here and below
| } | ||
| ``` | ||
|
|
||
| #### External Dependencies |
There was a problem hiding this comment.
why was this section removed?
There was a problem hiding this comment.
because externalDependencies option was removed ?
or this option is purely for webpack ?
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
3 participants
Here's a branch for refactoring. I'll put some changes that I find reasonable here.
Get involved and tell me what you would want to see here.
Fixes #95, Closes #142, Closes #93, Closes #77