WIP: add id support for future svelte version#124
Closed
AlbertMarashi wants to merge 2 commits intosveltejs:masterfrom
Closed
WIP: add id support for future svelte version#124AlbertMarashi wants to merge 2 commits intosveltejs:masterfrom
AlbertMarashi wants to merge 2 commits intosveltejs:masterfrom
Conversation
if there is a svelte v10, this won't break. This also grabs us the minor version so we can use it in the if statement once PR sveltejs/svelte#4856 is merged and released
This was referenced May 18, 2020
AlbertMarashi
changed the title
Author
|
sveltejs/svelte#4856 solves this problem without needing a change to svelte-loader |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sveltejs/svelte#4856