-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest Kit and handle breaking changes #270
Conversation
@geoffrich is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably keep using the npm tag next
in all of the package.json
files for Kit and its adapters.
It also doesn't look like what you're updating to is the latest version anymore.
Thanks, I made most of these changes yesterday and missed the new releases. Updated to actual latest and put |
This pull request is being automatically deployed with Vercel (learn more). hn – ./sites/hn.svelte.dev🔍 Inspect: https://vercel.com/svelte/hn/CTRgBB8csotzYHPYo79Z2vvDBKJS svelte-dev – ./sites/svelte.dev🔍 Inspect: https://vercel.com/svelte/svelte-dev/HaDUvp5gh7EsKWhYNKDekcGefWcs |
I'll do some validation on the preview deployments to make sure everything is working properly. |
Blocked by sveltejs/kit#3343 |
Thanks for fixing sveltejs/kit#3400 @geoffrich! Hopefully you're unblocked now, but let us know if there are any other issues remaining |
Waiting to leave draft state until I can E2E test, since this touches all functionality on the site (saving/deleting REPLs, login, etc). @benmccann can you authorize the preview deployment of svelte.dev to Vercel? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually I take back my approval 😄 since you've updated the site-kit
code I think you'll also need to upgrade kit.svelte.dev
to the latest version of SvelteKit as well or else I'm guessing that site will break since it depends on the workspace
version of site-kit
:
sites/sites/kit.svelte.dev/package.json
Line 14 in 99870b7
"@sveltejs/site-kit": "workspace:*", |
@benmccann I think I did -- see the pnpm lockfile. It also seems to work properly when running locally. Finished testing and everything looks good, so I think this is ready for final approval now. Login stuff didn't work on the preview deployment, but I assume that's because the GitHub OAuth is only set up for svelte.dev. Running locally I was able to login, logout, and save & delete REPLs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, yeah, you're right. I expected we would have at least one endpoint needing to be migrated in either the HN or SvelteKit sites, but I couldn't find any. I guess I forgot they're all in api.svelte.dev, so there's not really anything to do here
This PR updates the repo to the latest version of SvelteKit, and handles the breaking changes around
page
,query
, and the updatedRequest
andResponse
. This is a prerequisite for #245, which requires the change from next-215 to make the skip link work properly.