redirect svelte to svelte-ssr if building for ssr #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there something we should do to make sure we're using a version of Svelte that provides sveltejs/svelte#6416 before executing this new line of code? I'm not sure what's best (peer dep, runtime check with warning, silent runtime check, etc.) |
4 tasks
tanhauhau
commented
Jun 29, 2021
| @@ -50,6 +50,7 @@ module.exports = function (options = {}) { | |||
| */ | |||
| resolveId(importee, importer) { | |||
| if (cache_emit.has(importee)) return importee; | |||
| if (importee === 'svelte' && compilerOptions.generate === 'ssr') return this.resolve('svelte/ssr', importer, { skipSelf: true }); | |||
There was a problem hiding this comment.
need to check if the svelte version supports svelte/ssr
There was a problem hiding this comment.
maybe just test if svelte/ssr resolved and only return it if it did?
|
fyi, here's vite-plugin-svelte's implementation https://github.com/sveltejs/vite-plugin-svelte/blob/main/packages/vite-plugin-svelte/src/index.ts#L107 |
|
Closing this in favor of sveltejs/svelte#6743 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes sveltejs/svelte#6372