Skip to content

Conversation

@dummdidumm
Copy link
Member

@dummdidumm dummdidumm requested a review from jasonlyu123 May 17, 2023 19:47
@jasonlyu123
Copy link
Member

Overall looks good. There are two minor issues I found. Do we need an equivalent throwIfIsGeneric for the generic attribute? You can define generic on the module script now, but it doesn't do anything. I also notice that semantic tokens sometimes highlight script lang="ts" generic as a function. The current check needs to be more. I think we can skip the highlight if the highlighted identifier is render and if the mapped source includes a script tag.

@dummdidumm
Copy link
Member Author

I also notice that semantic tokens sometimes highlight script lang="ts" generic as a function.

Do you have a code snippet that reproduces this?

@jasonlyu123
Copy link
Member

<script lang="ts" generics="T extends string">

</script>

It's more apparent in a dark theme
圖片

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants