Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump source-map to fix crash in node 18.0 #1456

Closed
wants to merge 2 commits into from

Conversation

DetachHead
Copy link
Contributor

fixes #1455

@dummdidumm
Copy link
Member

dummdidumm commented Apr 22, 2022

We need to be careful bumping this. Many packages rely on source-map in one form of the other, and the beta version is used far less, which might lead to version resolution problems in some projects/with some packages.
Why does bumping the version fix the bug? Could we fix it in a different way?
Edit: I guess it's mozilla/source-map#349 and we can't fix that from the outside. More people will run into this in the long run, so yeah maybe we should bump the version.

@dummdidumm
Copy link
Member

Edit 2: I discovered https://github.com/jridgewell/trace-mapping, which is a drop-in-replacement (same API) for source-map which is lighter, faster, no WASN, sync, maintained -> we should switch to that.

@dummdidumm dummdidumm closed this Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem at runtime svelte-check
3 participants