-
-
Notifications
You must be signed in to change notification settings - Fork 223
Closed
Description
The new transformation which transforms Svelte to TS code instead of TSX code for intellisense purposes has been in beta for a while now, and I think it's stable enough to switch to it. This is a breaking change which needs some coordination, so I'm writing down the steps here:
- We want the new transformation to be more fine grained with respect to the allowed attributes on elements - for example only allow the
hrefonatags. At the same time we want to minimize the reliance onsvelte2tsx. Therefore we need these transformation in Svelte core. [feat] add html typings svelte#7649 adds these. Also (feat) enable actions to enhance typings on applied element #1553 for better action typings. (Update: Not merging the HTML PR for now) - Try out typings in [feat] add html typings svelte#7649 to see how we can incorporate them in
svelte2tsx - Test out things with SvelteNative (cc @halfnelson) and Svelte NodeGUI (cc @shirakaba ) - both likely need adjustments (adding the new required functions in the template and adding support for
on:Xevents). Depending on the outcome it may be better to bury our hopes of doingon:Xevent typings and instead keeponXtypings. - If experiments succeed, merge [feat] add html typings svelte#7649 and do a new release of Svelte
- Do one last release with the old transformation with any bug fixes that may have been merged in the meantime
- Merge (fix) keep colon while transforming events #1549 , adjust
svelte-jsx.d.tsso that the old typings are removed - only keep some of the interfaces that people might have used to enhance their typings. Add the typing mentioned in (fix) keep colon while transforming events #1549 so breakage on events is minimal for peole - Release a new version of the Svelte extension with the new transformation turned on by default
- Wait for a few weeks for bug reports or things we might have missed.
- Release
svelte-check3.0 with the new transformation only. This requires peer dependency bumps for Svelte and TypeScript. We should also bump the node version to latest 14 so we can bump the LSP version under the hood later without it being another breaking change
@jasonlyu123 what do you think about these steps? Did I miss anything?
gyurielf
Metadata
Metadata
Assignees
Labels
No labels