Skip to content

fix: Flaky test #9947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elliott-with-the-longest-name-on-github merged 6 commits into from
May 17, 2023
Merged

fix: Flaky test #9947

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
761b734
fix: Flaky test
elliott-with-the-longest-name-on-github May 17, 2023
08df73f
reuse locator
gtm-nayan May 17, 2023
eb597e3
add semi
gtm-nayan May 17, 2023
4121589
drive by test speed up
gtm-nayan May 17, 2023
fc964e9
another classic
gtm-nayan May 17, 2023
05a9137
oh my god brain, y u so bad
gtm-nayan May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions packages/kit/test/apps/basics/src/routes/actions/enhance/old-property-access/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,25 +28,33 @@
</script>

<form method="POST" action="?/form_submit" use:access_form_submit>
<button id="access-form-in-submit" type="submit"
>{form?.form_submit ? 'processed' : 'not processed'}</button
<button
id="access-form-in-submit"
type="submit"
data-processed={form?.form_submit ? 'true' : 'false'}>Access form in submit</button
>
</form>

<form method="POST" action="?/data_submit" use:access_data_submit>
<button id="access-data-in-submit" type="submit"
>{form?.data_submit ? 'processed' : 'not processed'}</button
<button
id="access-data-in-submit"
type="submit"
data-processed={form?.data_submit ? 'true' : 'false'}>Access data in submit</button
>
</form>

<form method="POST" action="?/form_callback" use:access_form_callback>
<button id="access-form-in-callback" type="submit"
>{form?.form_callback ? 'processed' : 'not processed'}</button
<button
id="access-form-in-callback"
type="submit"
data-processed={form?.form_callback ? 'true' : 'false'}>Access form in callback</button
>
</form>

<form method="POST" action="?/data_callback" use:access_data_callback>
<button id="access-data-in-callback" type="submit"
>{form?.data_callback ? 'processed' : 'not processed'}</button
<button
id="access-data-in-callback"
type="submit"
data-processed={form?.data_callback ? 'true' : 'false'}>Access data in callback</button
>
</form>
2 changes: 1 addition & 1 deletion packages/kit/test/apps/basics/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,7 +864,7 @@ test.describe('Actions', () => {
const log_promise = page.waitForEvent('console');
const button = page.locator(`#${id}`);
await button.click();
expect(await button.textContent()).toBe('processed'); // needed to make sure action completes
await expect(button).toHaveAttribute('data-processed', 'true')
Comment thread
gtm-nayan marked this conversation as resolved.
Outdated
const log = await log_promise;
expect(log.text()).toBe(
`\`${old_name}\` has been deprecated in favor of \`${new_name}\`. \`${old_name}\` will be removed in a future version. (Called from ${call_location})`
Expand Down