Skip to content

fix: ensure styles are loaded in dev mode for routes containing special characters #9894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich-Harris merged 5 commits into from
May 17, 2023
Merged

fix: ensure styles are loaded in dev mode for routes containing special characters #9894

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
839aad3
Fix loading styles for routes containing special characters in dev mode.
whataboutpereira May 10, 2023
e4be05e
Create stale-houses-yell.md
benmccann May 11, 2023
7b9f5c9
decodeURL inside if
whataboutpereira May 11, 2023
49068d5
merge master
May 16, 2023
cea820e
add test
May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/kit/src/exports/vite/dev/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ export async function dev(vite, vite_config, svelte_config) {
for (const dep of deps) {
const url = new URL(dep.url, 'http://localhost/');
const query = url.searchParams;
const pathname = decodeURI(url.pathname);

if (
isCSSRequest(dep.file) ||
Expand All @@ -187,9 +188,7 @@ export async function dev(vite, vite_config, svelte_config) {
query.set('inline', '');

try {
const mod = await loud_ssr_load_module(
`${url.pathname}${url.search}${url.hash}`
);
const mod = await loud_ssr_load_module(`${pathname}${url.search}${url.hash}`);
Comment thread
whataboutpereira marked this conversation as resolved.
Outdated
styles[dep.url] = mod.default;
} catch {
// this can happen with dynamically imported modules, I think
Expand Down