Skip to content

Avoid FOUC when using CSS modules in dev #9323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich-Harris merged 1 commit into from
Mar 6, 2023
Merged

Avoid FOUC when using CSS modules in dev #9323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lemon-beers-yawn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: avoid FOUC when using CSS modules in dev
11 changes: 8 additions & 3 deletions packages/kit/src/exports/vite/dev/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,15 +175,20 @@ export async function dev(vite, vite_config, svelte_config) {
const styles = {};

for (const dep of deps) {
const parsed = new URL(dep.url, 'http://localhost/');
const query = parsed.searchParams;
const url = new URL(dep.url, 'http://localhost/');
const query = url.searchParams;

if (
isCSSRequest(dep.file) ||
(query.has('svelte') && query.get('type') === 'style')
) {
// setting `?inline` to load CSS modules as css string
query.set('inline', '');
Comment thread
DrLoopFall marked this conversation as resolved.

try {
const mod = await loud_ssr_load_module(dep.url);
const mod = await loud_ssr_load_module(
`${url.pathname}${url.search}${url.hash}`
Comment thread
Rich-Harris marked this conversation as resolved.
);
styles[dep.url] = mod.default;
} catch {
// this can happen with dynamically imported modules, I think
Expand Down