Skip to content

chore: improve error message for prefetching invalid url #7314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich-Harris merged 4 commits into from
Oct 20, 2022
Merged

chore: improve error message for prefetching invalid url #7314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e435df4
docs: improve error message for external prefetching
dominikg Oct 19, 2022
052932e
add changeset
dominikg Oct 19, 2022
81e50b4
fix: changeset message
dominikg Oct 19, 2022
c3d9c27
fix: remove invalid extra information from prefetch error message
dominikg Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/twenty-monkeys-glow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

Improve error message when prefetching fails
2 changes: 1 addition & 1 deletion packages/kit/src/runtime/client/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ export function create_client({ target, base, trailing_slash }) {
const intent = get_navigation_intent(url, false);

if (!intent) {
throw new Error('Attempted to prefetch a URL that does not belong to this app');
throw new Error(`Attempted to prefetch a URL that does not belong to this app: ${url}`);
}

load_cache = { id: intent.id, promise: load_route(intent) };
Expand Down