Skip to content

[fix] add $types to includes for better DX #7301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich-Harris merged 2 commits into from
Oct 18, 2022
Merged

[fix] add $types to includes for better DX #7301

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f269f3
[fix] add $types to includes for better DX
dummdidumm Oct 18, 2022
e35fdf8
Update .changeset/spotty-kangaroos-peel.md
Rich-Harris Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/spotty-kangaroos-peel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

[fix] add \$types to includes for better DX
Comment thread
Rich-Harris marked this conversation as resolved.
Outdated
2 changes: 1 addition & 1 deletion packages/kit/src/core/sync/write_tsconfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export function write_tsconfig(config, cwd = process.cwd()) {
/** @param {string} file */
const config_relative = (file) => posixify(path.relative(config.outDir, file));

const include = ['ambient.d.ts', config_relative('vite.config.ts')];
const include = ['ambient.d.ts', './types/**/$types.d.ts', config_relative('vite.config.ts')];
for (const dir of [config.files.routes, config.files.lib]) {
const relative = project_relative(path.dirname(dir));
include.push(config_relative(`${relative}/**/*.js`));
Expand Down