Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in ignorePatterns for the generated TypeScript .eslintrc.cjs #701

Merged
merged 2 commits into from
Mar 26, 2021

Conversation

jimpala
Copy link
Contributor

@jimpala jimpala commented Mar 26, 2021

Just a small one - the .eslintrc.cjs config file optionally generated by create-svelte for TypeScript projects looks like it's trying to ignore itself via ignorePatterns (probably because it's using the TS ESLint parser but the config is in JS).
But it says .eslintrc.js in ignorePatterns, when the generated file actually has a .cjs extension!

Thanks so much for your work on the framework 😄

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@vercel
Copy link

vercel bot commented Mar 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sveltejs/kit/83F6G66UuN9BMfXpqGRjQtVpc2JT
✅ Preview: Canceled

[Deployment for bbe0845 canceled]

@dummdidumm
Copy link
Member

dummdidumm commented Mar 26, 2021

Good catch, thanks! Could add a changeset? You need to run pnpx changeset and then select create-svelte, patch release, and then add a short description.

@jimpala
Copy link
Contributor Author

jimpala commented Mar 26, 2021

@dummdidumm absolutely! That should be done for you 😄

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants