Skip to content

only run postinstall if package.json exists #6998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich-Harris merged 4 commits into from
Sep 23, 2022
Merged

only run postinstall if package.json exists #6998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c01d533
only run postinstall if package.json exists - closes #6987
Rich-Harris Sep 23, 2022
bea10b4
Update packages/kit/postinstall.js
Rich-Harris Sep 23, 2022
5aa97a0
belt and braces
Rich-Harris Sep 23, 2022
12befed
accommodate yarn's... idiosyncracies
Rich-Harris Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hungry-flowers-hope.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

Only run postinstall script if package.json exists
55 changes: 32 additions & 23 deletions packages/kit/postinstall.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,35 +4,44 @@ import glob from 'tiny-glob/sync.js';
import { load_config } from './src/core/config/index.js';
import * as sync from './src/core/sync/sync.js';

const cwd = process.env.INIT_CWD ?? process.cwd();
process.chdir(cwd);
try {
const cwd = process.env.INIT_CWD ?? process.cwd();
process.chdir(cwd);

const pkg = JSON.parse(fs.readFileSync('package.json', 'utf8'));
if (fs.existsSync('package.json')) {
const pkg = JSON.parse(fs.readFileSync('package.json', 'utf8'));

const directories = [];
const directories = [];

if (pkg.workspaces) {
for (const directory of pkg.workspaces) {
directories.push(...glob(directory, { cwd }).map((dir) => path.resolve(cwd, dir)));
}
} else {
directories.push(cwd);
}
if (pkg.workspaces) {
// we have to do this because of https://classic.yarnpkg.com/blog/2018/02/15/nohoist/
const packages = Array.isArray(pkg.workspaces) ? pkg.workspaces : pkg.workspaces.packages;

for (const cwd of directories) {
process.chdir(cwd);
for (const directory of packages) {
directories.push(...glob(directory, { cwd }).map((dir) => path.resolve(cwd, dir)));
}
} else {
directories.push(cwd);
}

for (const cwd of directories) {
process.chdir(cwd);

if (!fs.existsSync('package.json')) continue;
if (!fs.existsSync('svelte.config.js')) continue;
if (!fs.existsSync('package.json')) continue;
if (!fs.existsSync('svelte.config.js')) continue;

const pkg = JSON.parse(fs.readFileSync('package.json', 'utf8'));
if (!pkg.dependencies?.['@sveltejs/kit'] && !pkg.devDependencies?.['@sveltejs/kit']) continue;
const pkg = JSON.parse(fs.readFileSync('package.json', 'utf8'));
if (!pkg.dependencies?.['@sveltejs/kit'] && !pkg.devDependencies?.['@sveltejs/kit']) continue;

try {
const config = await load_config();
await sync.all(config, 'development');
} catch (e) {
console.log('Error while trying to sync SvelteKit config');
console.log(e);
try {
const config = await load_config();
await sync.all(config, 'development');
} catch (error) {
console.log('Error while trying to sync SvelteKit config');
console.log(error.stack);
}
}
}
} catch (error) {
console.error(error.stack);
}