Skip to content

Alternative to #5520 #5536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich-Harris merged 9 commits into from
Jul 14, 2022
Merged

Alternative to #5520 #5536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
56754ea
loop over values instead with `Object.values`
ignatiusmb Jul 14, 2022
0e7bfe3
missed a closing bracket
ignatiusmb Jul 14, 2022
6405386
avoid concealing build errors
gtm-nayan Jul 14, 2022
2f845d1
fix comment
gtm-nayan Jul 14, 2022
9ac7ca8
changeset
gtm-nayan Jul 14, 2022
7c2e838
Handle errors in writeBundle
gtm-nayan Jul 14, 2022
681d785
inline comments
gtm-nayan Jul 14, 2022
e985f35
track success rather than failure
Rich-Harris Jul 14, 2022
a211e34
oops, missing piece
Rich-Harris Jul 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/large-seahorses-check.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: don't try adapting if build failed
11 changes: 9 additions & 2 deletions packages/kit/src/vite/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,8 @@ function kit() {
*/
let paths;

let completed_build = false;

function vite_client_config() {
/** @type {Record<string, string>} */
const input = {
Expand Down Expand Up @@ -345,15 +347,20 @@ function kit() {
console.log(
`\nRun ${colors.bold().cyan('npm run preview')} to preview your production build locally.`
);

completed_build = true;
},

/**
* Runs the adapter.
*/
async closeBundle() {
if (!is_build) {
return; // vite calls closeBundle when dev-server restarts, ignore that
if (!completed_build) {
// vite calls closeBundle when dev-server restarts, ignore that,
// and only adapt when build successfully completes.
return;
}

if (svelte_config.kit.adapter) {
const { adapt } = await import('../core/adapt/index.js');
await adapt(svelte_config, build_data, prerendered, { log });
Expand Down