add out option to adapter-node, and add types for adapters #531
Conversation
| @@ -1,3 +1,5 @@ | |||
| import { Logger } from './types.internal'; | |||
There was a problem hiding this comment.
It seems like Logger isn't really an internal type if it's being exposed here. Why not just put it in this file?
There was a problem hiding this comment.
it's internal insofar as you're not going to do
/** @type {import('@sveltejs/kit').Logger} */— it's always just a property of the builder (which also needn't be exported) that's passed to the adapt function. this file should only export types that need to be consumed by users of Kit
| * out?: string; | ||
| * }} options | ||
| */ | ||
| export default function ({ out = 'build' } = {}) { |
There was a problem hiding this comment.
should we have an interface for this?
There was a problem hiding this comment.
nah, it's adapter-specific
| @@ -1,8 +1,8 @@ | |||
| /** | |||
| * @param {import('../../types').Request} request | |||
| * @param {import('../../../types.internal').Request} request | |||
There was a problem hiding this comment.
I would expect that Request and Response should not be internal because almost every adapter will have to deal with them
There was a problem hiding this comment.
probably. we can move things out of internal as and when necessary
|
Tests are failing but I'm pretty confident it's entirely due to flakiness rather than anything in this PR, so I'll merge this |
Makes the output directory for
adapter-nodeconfigurable. While I was at it, I added anAdaptertype, but haven't yet applied it to the other adapters.This entailed moving some types out of
kit/src/types.d.tsintokit/types.internal.d.tsso that they can more easily get included in the package, which makes the PR look much bigger than it is.