chore: finish ESM conversion #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have to replicate the `uvu` internals since all internal loader/iterator logic is bypassed.
- chasing unterminated process
- so that `dev.close` is await'able
- also part of what uvu cli does; derp
Member
Author
|
@Rich-Harris tests pass -- not sure what the rest of the red is about |
Member
|
Thank you. All this stuff... // manually replicate uvu global state
const count = globalThis.UVU_QUEUE.push([name]);
globalThis.UVU_INDEX = count - 1;...feels a bit sketchy, do you think there's a future where there's a more idiomatic approach? |
Member
Author
|
Perhaps, but no promises. It's uvu internals, which are currently exposed because you've opted out of uvu's entire control flow. I think it's fair & very minimal, tho I do agree it'd feel nicer if it was given a mask/method name. |
Rich-Harris
pushed a commit
that referenced
this pull request
Feb 10, 2021
* start converting everything to ESM * more stuff * chore: finish ESM conversion (#360) * fix(test): manually control `UVU_QUEUE` positions; Have to replicate the `uvu` internals since all internal loader/iterator logic is bypassed. * fix: force `UVU_QUEUE` values * chore: add `context.reset` method; - chasing unterminated process * fix(kit): return `snowpack.shutdown` promise - so that `dev.close` is await'able * fix(runner): manually exit process; - also part of what uvu cli does; derp * chore: convert "test/apps/basics" fixture * chore: convert "test/apps/options" fixture * bump meriyah * all tests passing, i think? * simplify * get CLI working * brute force Co-authored-by: Luke Edwards <[email protected]>
benmccann
pushed a commit
that referenced
this pull request
Feb 10, 2021
* start converting everything to ESM * more stuff * chore: finish ESM conversion (#360) * fix(test): manually control `UVU_QUEUE` positions; Have to replicate the `uvu` internals since all internal loader/iterator logic is bypassed. * fix: force `UVU_QUEUE` values * chore: add `context.reset` method; - chasing unterminated process * fix(kit): return `snowpack.shutdown` promise - so that `dev.close` is await'able * fix(runner): manually exit process; - also part of what uvu cli does; derp * chore: convert "test/apps/basics" fixture * chore: convert "test/apps/options" fixture * bump meriyah * all tests passing, i think? * simplify * get CLI working * brute force Co-authored-by: Luke Edwards <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the missing bits & converted the remaining test apps.