Skip to content

[fix] Server-side fetch request should have headers (#696) #2861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aolose wants to merge 5 commits into from
Closed

[fix] Server-side fetch request should have headers (#696) #2861

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d56bf6f
Merge headers from request
Nov 22, 2021
d85b9bc
format
Nov 22, 2021
ac9a9d6
Merge branch 'sveltejs:master' into master
aolose Nov 23, 2021
699608c
Merge branch 'sveltejs:master' into master
aolose Nov 24, 2021
0927c32
Merge branch 'sveltejs:master' into master
aolose Nov 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/kit/src/runtime/server/page/load_node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,12 @@ export async function load_node({
};
}

//merge headers from request
Copy link
Member

@benmccann benmccann Nov 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we usually put a space after //

Suggested change
//merge headers from request
// merge headers from request

Copy link
Member

@bluwy bluwy Nov 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two spaces between words too, we should have one space only.

opts.headers = {
...request.headers,
...opts.headers
};

const resolved = resolve(request.path, url.split('?')[0]);

let response;
Expand Down