Skip to content

hotfix: with nodeAdapter we should get fetch from globalThis #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stalkerg wants to merge 1 commit into from
Closed

hotfix: with nodeAdapter we should get fetch from globalThis #1786

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/kit/src/core/dev/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ class Watcher extends EventEmitter {
hooks: {
getSession: hooks.getSession || (() => ({})),
handle: hooks.handle || (({ request, resolve }) => resolve(request)),
serverFetch: hooks.serverFetch || fetch
serverFetch: hooks.serverFetch || globalThis.fetch
Copy link
Member

@GrygrFlzr GrygrFlzr Jun 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the fetch call inside serverFetch? Does that also need to be scoped with globalThis., or does this only affect the default case of not having serverFetch defined?

Copy link
Contributor Author

@stalkerg stalkerg Jun 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it's fallback, serverFetch is optional.

Copy link
Contributor Author

@stalkerg stalkerg Jun 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or does this only affect the default case of not having serverFetch defined?

yes.

},
hydrate: this.config.kit.hydrate,
paths: this.config.kit.paths,
Expand Down