Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts to address #166, by creating a
Builder
class (naming subject to yak-shaving) that gets passed to adapters. The idea is that rather than adapters making assumptions about file structure and having to import various helper functions from app-utils, everything is co-located in a way that reduces code duplication etc.So
adapter-static
goes from this......to this:
Not pictured: a way for the adapter to verify that the builder API is the version that it expects (e.g.
builder.check_version('^1.0.0')
, which would throw if the version of@sveltejs/kit
that provided the builder was at version 2.0.0 or above).My progress has been somewhat hampered by TypeScript errors that are preventing me from actually writing the PR.