Skip to content

chore: fix type checking in client test #15303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benmccann merged 3 commits into from
Feb 12, 2026
Merged

chore: fix type checking in client test #15303

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c9b6af
chore: fix type checking in client test
benmccann Feb 12, 2026
25f7a85
address comment
benmccann Feb 12, 2026
3ffaad8
fix
benmccann Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions packages/kit/test/apps/basics/test/cross-platform/client.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
test.describe.configure({ mode: 'parallel' });

test.describe('a11y', () => {
test('resets focus', async ({ page, clicknav, browserName }) => {

Check warning on line 12 in packages/kit/test/apps/basics/test/cross-platform/client.test.js

View workflow job for this annotation

GitHub Actions / test-kit-cross-browser (24, windows-latest, chromium, dev)

flaky test: resets focus 

retries: 2
const tab = browserName === 'webkit' ? 'Alt+Tab' : 'Tab';

await page.goto('/accessibility/a');
Expand All @@ -32,7 +32,7 @@
expect(await page.evaluate(() => document.documentElement.getAttribute('tabindex'))).toBe(null);
});

test('applies autofocus after a navigation', async ({ page, clicknav }) => {

Check warning on line 35 in packages/kit/test/apps/basics/test/cross-platform/client.test.js

View workflow job for this annotation

GitHub Actions / test-kit-cross-browser (24, windows-latest, chromium, dev)

flaky test: applies autofocus after a navigation 

retries: 2
await page.goto('/accessibility/autofocus/a');

await clicknav('[href="/accessibility/autofocus/b"]', {
Expand Down Expand Up @@ -326,9 +326,9 @@
await page.goto('/navigation-lifecycle/scroll-state/a');
await scroll_to(0, 500);

/** @type {any} */
let beforeNav, onNav, afterNav;
const navPromise = new Promise((resolve) => {
/** @type {any} */
let beforeNav, onNav, afterNav;
page.on('console', (msg) => {
const text = msg.text();
if (text.startsWith('beforeNavigate:')) {
Expand All @@ -339,12 +339,12 @@
afterNav = JSON.parse(text.slice('afterNavigate:'.length));
}

if (beforeNav && onNav && afterNav) resolve(undefined);
if (beforeNav && onNav && afterNav) resolve({ beforeNav, onNav, afterNav });
});
});

await clicknav('#to-b');
await navPromise;
const { beforeNav, onNav, afterNav } = await navPromise;

expect(beforeNav.fromScroll).toEqual({ x: 0, y: 500 });
expect(beforeNav.toScroll).toBe(null);
Expand Down Expand Up @@ -380,9 +380,9 @@

const savedScrollY = afterNav.fromScroll.y;

/** @type {any} */
let beforeNav, onNav;
navPromise = new Promise((resolve) => {
/** @type {any} */
let beforeNav, onNav, afterNav;
page.on('console', (msg) => {
const text = msg.text();
if (text.startsWith('beforeNavigate:')) {
Expand All @@ -393,13 +393,15 @@
afterNav = JSON.parse(text.slice('afterNavigate:'.length));
}

if (beforeNav && onNav && afterNav) resolve(undefined);
if (beforeNav && onNav && afterNav) resolve({ beforeNav, onNav, afterNav });
});
});

await page.goBack();
await page.waitForURL('/navigation-lifecycle/scroll-state/a');
await navPromise;
/** @type {any} */
let beforeNav, onNav;
({ beforeNav, onNav, afterNav } = await navPromise);

expect(beforeNav.fromScroll).toEqual({ x: 0, y: 0 });
expect(beforeNav.toScroll).toEqual({ x: 0, y: savedScrollY });
Expand Down Expand Up @@ -488,7 +490,7 @@
expect(await in_view('#go-to-element')).toBe(true);
});

test('no-anchor url will scroll to top when navigated from bottom of page', async ({

Check warning on line 493 in packages/kit/test/apps/basics/test/cross-platform/client.test.js

View workflow job for this annotation

GitHub Actions / test-kit (24, ubuntu-latest, chromium, current)

flaky test: no-anchor url will scroll to top when navigated from bottom of page 

retries: 2
clicknav,
page
}) => {
Expand Down Expand Up @@ -876,7 +878,7 @@
await expect(page.locator('p')).toHaveText('Loaded 1 times.');
});

test('does rerun load when preload errored', async ({ app, page }) => {

Check warning on line 881 in packages/kit/test/apps/basics/test/cross-platform/client.test.js

View workflow job for this annotation

GitHub Actions / test-kit-cross-browser (24, windows-latest, chromium, build)

flaky test: does rerun load when preload errored 

retries: 2
await page.goto('/routing/a');

await app.preloadData('/routing/preloading/preload-error');
Expand Down
Loading