Skip to content

fix: don't send "Vary: Accept-Encoding" header when precompress=false #15182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teemingc merged 3 commits into from
Jan 20, 2026
Merged

fix: don't send "Vary: Accept-Encoding" header when precompress=false #15182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de4277b
Disable sirv compression checks when precompress=false
theandrew168 Jan 17, 2026
66a6cb3
Add changeset
theandrew168 Jan 17, 2026
ded4df2
Update .changeset/sweet-spoons-study.md
elliott-with-the-longest-name-on-github Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sweet-spoons-study.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/adapter-node': patch
---

fix: disable gzip and brotli when precompress=false
1 change: 1 addition & 0 deletions packages/adapter-node/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import './ambient.js';

declare global {
const ENV_PREFIX: string;
const PRECOMPRESS: boolean;
}

interface AdapterOptions {
Expand Down
3 changes: 2 additions & 1 deletion packages/adapter-node/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@ export default function (opts = {}) {
MANIFEST: './server/manifest.js',
SERVER: './server/index.js',
SHIMS: './shims.js',
ENV_PREFIX: JSON.stringify(envPrefix)
ENV_PREFIX: JSON.stringify(envPrefix),
PRECOMPRESS: JSON.stringify(precompress)
}
});

Expand Down
5 changes: 3 additions & 2 deletions packages/adapter-node/src/handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { env } from 'ENV';
import { parse_as_bytes } from '../utils.js';

/* global ENV_PREFIX */
/* global PRECOMPRESS */

const server = new Server(manifest);

Expand Down Expand Up @@ -47,8 +48,8 @@ function serve(path, client = false) {
return fs.existsSync(path)
? sirv(path, {
etag: true,
gzip: true,
brotli: true,
gzip: PRECOMPRESS,
brotli: PRECOMPRESS,
setHeaders: client
? (res, pathname) => {
// only apply to build directory, not e.g. version.json
Expand Down
Loading